Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update of Video Player to 2.8.1 #2113

Conversation

vaidic-dodwani
Copy link
Contributor

@vaidic-dodwani vaidic-dodwani commented Nov 18, 2023

What kind of change does this PR introduce?

This change included the bumping of video_player package from 2.7.2 to 2.8.1.

Issue Number:

Fixed #2091

Did you add tests for your changes?

No tests are required for this change as it only includes a package update.

If relevant, did you update the documentation?

updating the documentation isnt required for this.

Summary

It upgrades the video_player to 2.8.1 for enhanceability.

Does this PR introduce a breaking change?

No, this does not introduce any major changes to the codebase.

Have you read the contributing guide?

Yes, i have followed the guidelines.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.

Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4603ad1) 76.97% compared to head (965a1a8) 77.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2113      +/-   ##
===========================================
+ Coverage    76.97%   77.18%   +0.21%     
===========================================
  Files          152      152              
  Lines         7456     7456              
===========================================
+ Hits          5739     5755      +16     
+ Misses        1717     1701      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaidic-dodwani
Copy link
Contributor Author

@palisadoes hey, i have completed the pull request revision. The only remaining step is to grant permission for modifying unauthorized_files.

@palisadoes
Copy link
Contributor

Do not modify any protected files or the checks for them. We have them for the previously stated reason.

@vaidic-dodwani
Copy link
Contributor Author

@palisadoes what do you suggest i should do next for this issue, as it only needs a version update and it wont be possible without changing the pubspec.yaml

@palisadoes
Copy link
Contributor

Edit the file but not the GitHub action configuration file

@vaidic-dodwani
Copy link
Contributor Author

@palisadoes I apologize for any misunderstandings I may have created. I just made changes to the pubspec.yaml file for the update and have not edited any GitHub Actions files.

@Dante291
Copy link
Contributor

Hello @vaidic-dodwani you're only pushing yaml file however whenever you upgade any package in yaml, pubspec.lock file also make changes according to it so you need to push that file too. You can take refrence from the dependabot's PR.

@palisadoes
Copy link
Contributor

@aashimawadhwa will be handling all issue queries and seeking reviewers for PRs. When necessary, this contributor will contact other contributors who will be able to assist. Please ask them for guidance on your future questions.

@palisadoes palisadoes merged commit fec1a2e into PalisadoesFoundation:develop Nov 20, 2023
7 of 8 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
* Version update of Video Player to 2.8.1

* Modified: pubspec.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade package video_player from 2.7.2 to 2.8.1
4 participants